Обсуждение: Bug in dlgCast

Dear all,

I just encountered a bug in 1.2.0 Beta 2 (Win XP).

When selecting the source or target type in the "New Cast" dialog, the
application crashes. What IMHO happens is that the call to
txtName->SetValue(wxEmptyString) in dlgCast::CheckChange()
(src/ui/dlgCast.cpp line 121) generates a new wxEVT_COMMAND_TEXT_UPDATED
event. This event triggers a call to dlgProperty::OnChange() which in
turn calls the virtual dlgCast::CheckChange() and so on ... until
pgAdmin crashes.

Unfortunately I have no idea how to fix this,

Alex

Alexander Borkowski wrote:
> Dear all,
>
> I just encountered a bug in 1.2.0 Beta 2 (Win XP).
>
> When selecting the source or target type in the "New Cast" dialog, the
> application crashes. What IMHO happens is that the call to
> txtName->SetValue(wxEmptyString) in dlgCast::CheckChange()
> (src/ui/dlgCast.cpp line 121) generates a new wxEVT_COMMAND_TEXT_UPDATED
> event. This event triggers a call to dlgProperty::OnChange() which in
> turn calls the virtual dlgCast::CheckChange() and so on ... until
> pgAdmin crashes.

Your analysis is right. The problem is that txtName is handled in a
generalized way in dlgProperty, which handles user inputs, but in the
case of dlgCast it's a calculated non-editable name.

Fix: renamed to txtCastname.

Thanks for reporting!

Regards,
Andreas

Andreas Pflug wrote:

> Thanks for reporting!

Thanks for fixing! :-)

Alex