Обсуждение: Bug in CREATE USER script

Create script for user have a serious bug:

CREATE USER test
  WITH SYSID 101
  PASSWORD ENCRYPTED md5c104555d849cf47bd82febf072dd479c
  NOCREATEDB NOCREATEUSER;

and it should be :

CREATE USER test
  WITH SYSID 101
  ENCRYPTED PASSWORD 'md5c104555d849cf47bd82febf072dd479c'
  NOCREATEDB NOCREATEUSER;

Please change the order of  ENCRYPTED and PASSWORD keywords and quote the
password string, or should I do the patch ?
Regards !

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> Darko Prenosil
> Sent: 13 August 2004 21:59
> To: pgadmin-hackers@postgresql.org
> Subject: [pgadmin-hackers] Bug in CREATE USER script
>
>
> Please change the order of  ENCRYPTED and PASSWORD keywords
> and quote the password string, or should I do the patch ?
> Regards !

A patch in diff -c format would be great if you have a few minutes to do
one :-)

Thanks, Dave.

Here it is as I promised !
Regards !

On Saturday 14 August 2004 00:41, Dave Page wrote:
> > -----Original Message-----
> > From: pgadmin-hackers-owner@postgresql.org
> > [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> > Darko Prenosil
> > Sent: 13 August 2004 21:59
> > To: pgadmin-hackers@postgresql.org
> > Subject: [pgadmin-hackers] Bug in CREATE USER script
> >
> >
> > Please change the order of  ENCRYPTED and PASSWORD keywords
> > and quote the password string, or should I do the patch ?
> > Regards !
>
> A patch in diff -c format would be great if you have a few minutes to do
> one :-)
>
> Thanks, Dave.
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

Patch is not committed yet. Is there something wrong with it, or is it lost
?

Regards !

----- Original Message -----
From: "Dave Page" <dpage@vale-housing.co.uk>
To: "Darko Prenosil" <Darko.Prenosil@finteh.hr>;
<pgadmin-hackers@postgresql.org>
Sent: Saturday, August 14, 2004 12:41 AM
Subject: Re: [pgadmin-hackers] Bug in CREATE USER script




> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> Darko Prenosil
> Sent: 13 August 2004 21:59
> To: pgadmin-hackers@postgresql.org
> Subject: [pgadmin-hackers] Bug in CREATE USER script
>
>
> Please change the order of  ENCRYPTED and PASSWORD keywords
> and quote the password string, or should I do the patch ?
> Regards !

A patch in diff -c format would be great if you have a few minutes to do
one :-)

Thanks, Dave.

---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> Darko Prenosil
> Sent: 16 August 2004 18:51
> To: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] Bug in CREATE USER script
>
> Patch is not committed yet. Is there something wrong with it,
> or is it lost ?
>

No, just doing it this very second - I've been off work decorating and
shopping all weekend!!

Regards, Dave.

> -----Original Message-----
> From: Darko Prenosil [mailto:darko.prenosil@finteh.hr]
> Sent: 14 August 2004 12:58
> To: Dave Page
> Cc: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] Bug in CREATE USER script
>
> Here it is as I promised !
> Regards !

Thanks, patch applied.

Regards, Dave.