Обсуждение: autoconf compiling *.c
Hi Adam, for support of keyword checking, we need to include keywords.c. I added this to makefile.am, but the compile flags will lacke the including of the main include dir (../src/include in my build). While we have agreed not to activate this for the 1.0 release, we'll need this quite soon. Please have a look where to add the options so we can compile *.c successfully. Regards, Andreas
Andreas Pflug wrote: > Hi Adam, > > for support of keyword checking, we need to include keywords.c. I > added this to makefile.am, but the compile flags will lacke the > including of the main include dir (../src/include in my build). While > we have agreed not to activate this for the 1.0 release, we'll need > this quite soon. Please have a look where to add the options so we can > compile *.c successfully. > > Regards, > Andreas > > > I'm not sure I quite understand; what happens when you add db/keywords.c to Makefile.am, run bootstrap, re-run configure, and re-compile? ahp
Adam H. Pendleton wrote: > Andreas Pflug wrote: > >> Hi Adam, >> >> for support of keyword checking, we need to include keywords.c. I >> added this to makefile.am, but the compile flags will lacke the >> including of the main include dir (../src/include in my build). While >> we have agreed not to activate this for the 1.0 release, we'll need >> this quite soon. Please have a look where to add the options so we >> can compile *.c successfully. >> >> Regards, >> Andreas >> >> >> > I'm not sure I quite understand; what happens when you add > db/keywords.c to Makefile.am, run bootstrap, re-run configure, and > re-compile? Hi Adam, if I do that, the private includes are not found. Regards, Andreas
Adam H. Pendleton wrote: > Andreas Pflug wrote: > >> Hi Adam, >> >> for support of keyword checking, we need to include keywords.c. I >> added this to makefile.am, but the compile flags will lacke the >> including of the main include dir (../src/include in my build). While >> we have agreed not to activate this for the 1.0 release, we'll need >> this quite soon. Please have a look where to add the options so we >> can compile *.c successfully. >> >> Regards, >> Andreas >> >> >> > I'm not sure I quite understand; what happens when you add > db/keywords.c to Makefile.am, run bootstrap, re-run configure, and > re-compile? > Adam, there's a new patch for acinclude.m4 statinc "search for PostgreSQL includes in /usr/include and usr/include/pgsql" is this supposed to fix this topic? It doesn't; try adding db/keywords.c to Makefile.am yourself. The files that keywords.c is missing are *not* to be used from a PostgreSQL installation, but should be found in our pgAdmin include directory. Some of the files needed are indeed original PostgreSQL backend files, and some are new pgAdmin versions. Regards, Andreas
> -----Original Message----- > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > Sent: 11 September 2003 11:24 > To: Adam H. Pendleton > Cc: pgadmin-hackers > Subject: Re: [pgadmin-hackers] autoconf compiling *.c > > > there's a new patch for acinclude.m4 statinc "search for PostgreSQL > includes in /usr/include and usr/include/pgsql" is this > supposed to fix > this topic? No, that's to help find PostgreSQL include files which are in /usr/include/pgsql on Suse apparently. Regards, Dave.
Le Jeudi 11 Septembre 2003 13:10, Dave Page a écrit : > No, that's to help find PostgreSQL include files which are in > /usr/include/pgsql on Suse apparently. The SRPM now recompiles on any RPM platform (RedHat, Mandrake, SuSE). Thanks Adam. Cheers, Jean-Michel
Andreas Pflug wrote: > Adam, > > there's a new patch for acinclude.m4 statinc "search for PostgreSQL > includes in /usr/include and usr/include/pgsql" is this supposed to > fix this topic? > It doesn't; try adding db/keywords.c to Makefile.am yourself. The > files that keywords.c is missing are *not* to be used from a > PostgreSQL installation, but should be found in our pgAdmin include > directory. Some of the files needed are indeed original PostgreSQL > backend files, and some are new pgAdmin versions. > > Regards, > Andreas > > > No, this patch is for a different issue. I am still working on yours. ahp
Attached is a patch to src/Makefile.am that fixes your problems. ahp --- pgadmin3/src/Makefile.am 2003-09-12 11:11:04.000000000 -0400 +++ pgadmin3.new/src/Makefile.am 2003-09-12 11:04:50.000000000 -0400 @@ -8,7 +8,7 @@ # db/keywords.c needs to be added pgadmin3_SOURCES = pgAdmin3.cpp \ -db/pgConn.cpp db/pgSet.cpp \ +db/pgConn.cpp db/pgSet.cpp db/keywords.c \ schema/pgAggregate.cpp schema/pgCast.cpp \ schema/pgCheck.cpp schema/pgCollection.cpp \ schema/pgColumn.cpp schema/pgConstraints.cpp \ @@ -188,3 +188,4 @@ ui/zh_CN/wxstd.mo AM_CXXFLAGS = -DDATA_DIR=\"$(pkgdatadir)/\" -Wall -g -I$(top_srcdir)/src/include -I$(WX_HOME) +AM_CPPFLAGS = -DDATA_DIR=\"$(pkgdatadir)/\" -Wall -g -I$(top_srcdir)/src/include -I$(WX_HOME)
Thanks Adam, patch applied. Regards, Dave. > -----Original Message----- > From: Adam H. Pendleton [mailto:fmonkey@fmonkey.net] > Sent: 12 September 2003 16:13 > To: Andreas Pflug > Cc: pgadmin-hackers > Subject: Re: [pgadmin-hackers] autoconf compiling *.c > > > Attached is a patch to src/Makefile.am that fixes your problems. > > ahp >