Re: Remove useless pointer advance in StatsShmemInit()

Hi,

On 2025-12-02 07:40:44 +0000, Bertrand Drouvot wrote:
> From 2fefb69f1462ce1057bb5c3d07ed70c769ec961a Mon Sep 17 00:00:00 2001
> From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
> Date: Sat, 22 Nov 2025 14:47:25 +0000
> Subject: [PATCH v1] Remove useless pointer updates
> 
> Same idea as in commit 9b7eb6f02e8. Those pointers are updated but are not used
> after the updates, so let's remove the useless updates or document why we want
> to keep them.

I think this is a bad idea. To the degree that I think 9b7eb6f02e8 ought to be
reverted.  All these changes do is to make future extensions of the relevant
code more failure prone. Omitting the pointer update means that the pointer
at the end points before the last "chunk", rather than at the end.

What's the point of this? Compilers are perfectly capable of removing a
trailing store if the updated value isn't ever used afterwards.

Greetings,

Andres