Hi,
On 2024-12-03 13:37:48 +0300, Anton A. Melnikov wrote:
> Found a place in the code of this patch that is unclear to me:
>
https://github.com/postgres/postgres/blob/1acf10549e64c6a52ced570d712fcba1a2f5d1ec/src/backend/utils/activity/pgstat.c#L1658
>
> Owing assert() the next if() should never be performed, but the comment above says the opposite.
> Is this assert really needed here? And if so, for what?
It's code that should be unreachable. But in case it is encountered in a
production scenario, it's not worth taking down the server for it.
Greetings,
Andres Freund