Re: Re: Added prosupport function for estimating numeric generate_series rows

On Fri, 29 Nov 2024 at 13:10, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:

>

> There are a couple more things that I think need tidying up. I'll post an update when I get back to my computer.

>

 

Here's an update with some cosmetic tidying up, plus a couple of

not-so-cosmetic changes:

 

The new #include wasn't in the right place alphabetically (the same is

true for the recent timestamp equivalent function).

 

It's not necessary to call init_var() for a variable that you're going

to initialise with init_var_from_num(), and it's then not necessary to

call free_var() for that variable.

 

It's not necessary to have separate NumericVars for the difference and

quotient -- the same variable can be reused.

 

Doing both those things means that there's only one variable to free

after the computation, and it can be kept local to if-step-not-zero

code block, so there's no need for the "goto cleanup" stuff.

 

It seems worth avoiding div_var() in the 2-argument case, when step = 1.

 

Regards,

Dean