Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state

Поиск
Список
Период
Сортировка
От cca5507
Тема Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state
Дата
Msg-id tencent_8DEC9842690A9B6AFD52D4659EF0700E9409@qq.com
обсуждение исходный текст
Ответ на Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state  ("cca5507" <cca5507@qq.com>)
Ответы Re: Historic snapshot doesn't track txns committed in BUILDING_SNAPSHOT state
Список pgsql-hackers
Дерево обсуждения
Hi,

4, 5 ===

> if (SnapBuildCurrentState(builder) < SNAPBUILD_BUILDING_SNAPSHOT ||
>     (SnapBuildCurrentState(builder) == SNAPBUILD_BUILDING_SNAPSHOT && info != XLOG_HEAP_INPLACE) ||
>     ctx->fast_forward)
>     return;

I think during fast forward, we also need handle the xlog that marks a transaction
as catalog modifying, or the snapshot might lose some transactions?

> That way we'd still rely on what's being done in the XLOG_HEAP_INPLACE case

+ if (SnapBuildCurrentState(builder) >= SNAPBUILD_BUILDING_SNAPSHOT)
+ {
+ /* Currently only XLOG_HEAP_INPLACE means a catalog modifying */
+ if (info == XLOG_HEAP_INPLACE && TransactionIdIsValid(xid))
+ ReorderBufferXidSetCatalogChanges(ctx->reorder, xid, buf->origptr);
+ }

We only call ReorderBufferXidSetCatalogChanges() for the xlog that marks a transaction as catalog
modifying, and we don't care about the other steps being done in the xlog, so I think the current
approach is ok.

--
Regards,
ChangAo Chen

В списке pgsql-hackers по дате отправления: