Hi all,
While reviewing the zstd code, I noticed two minor issues in astreamer_zstd.c that appear to be errors:
First, the file header comment for astreamer_zstd_compressor incorrectly references "lz4 compression" instead of "zstd
compression"— this looks like a copy-paste error from astreamer_lz4.c.
Second, in the astreamer_zstd_decompressor_finalize function, it seems there may be an error in parameter passing: the
functionuses the full buffer capacity (bbs_buffer.maxlen) when calling astreamer_content, rather than the actual length
ofdecompressed data (zstd_outBuf.pos).
I’ve attached two patches to address these potential issues:
0001: Fixes the incorrect comment in the astreamer_zstd.c header
0002: Corrects the parameter passed to astreamer_content in astreamer_zstd_decompressor_finalize
--
Regards,
Man Zeng
www.openhalo.org