Re: BUG #17821: Assertion failed in heap_update() due to heap pruning

Hi,

On 2025-01-22 18:13:49 -0800, Noah Misch wrote:
> Attached.  Outside of comments and tests, it's a simple 20-line patch.  Since
> only two weeks will remain before release freeze, in the absence of review, I
> would push this after 2025-01-25T16:00+0000.

I just fixed skink, the valgrind animal, so it runs not just the main
regression tests but all tests with a valgrind-ified postgres.  Unfortunately,
the next run triggered a failure in the test added in this thread:


https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=skink&dt=2025-03-03%2019%3A52%3A38&stg=injection_points-check

diff -U3
/home/bf/bf-build/skink-master/HEAD/pgsql/src/test/modules/injection_points/expected/syscache-update-pruned.out
/home/bf/bf-build/skink-master/HEAD/pgsql.build/testrun/injection_points/isolation/results/syscache-update-pruned.out
--- /home/bf/bf-build/skink-master/HEAD/pgsql/src/test/modules/injection_points/expected/syscache-update-pruned.out
2025-01-2519:30:50.005386842 +0000
 
+++
/home/bf/bf-build/skink-master/HEAD/pgsql.build/testrun/injection_points/isolation/results/syscache-update-pruned.out
2025-03-0321:08:02.025314915 +0000
 
@@ -75,6 +75,7 @@
     SELECT FROM injection_points_wakeup('heap_update-before-pin');
  <waiting ...>
 step grant1: <... completed>
+ERROR:  tuple concurrently deleted
 step wakegrant4: <... completed>
 step inspect4:
     SELECT relhastriggers, relhassubclass FROM pg_class
@@ -82,6 +83,6 @@

 relhastriggers|relhassubclass
 --------------+--------------
-f             |f
+t             |t
 (1 row)

Greetings,

Andres Freund