I/O worker and ConfigReload
| От | Dmitry Dolgov |
|---|---|
| Тема | I/O worker and ConfigReload |
| Дата | |
| Msg-id | sh5uqe4a4aqo5zkkpfy5fobe2rg2zzouctdjz7kou4t74c66ql@yzpkxb7pgoxf обсуждение исходный текст |
| Ответы |
Re: I/O worker and ConfigReload
|
| Список | pgsql-hackers |
Hi, I've been rebasing the patch for online resizing of shared memory, and noticed something strange about IoWorkerMain: although it sets the handler SignalHandlerForConfigReload, it doesn't look like it acts upon ConfigReloadPending. From what I see it happens because it only does CHECK_FOR_INTERRUPTS in the main worker loop, which doesn't handle ConfigReloadPending. In the context of shared memory resizing patch it means I/O workers are not receiving the new value of NBuffers and crash. Adding something like pgaio_worker_process_interrupts to deal with ConfigReloadPending at the beginning of the main worker loop seems to solve the issue. But I haven't found any discussion about config reload in I/O workers, was this omission intentional?
В списке pgsql-hackers по дате отправления: