Re: Release 1204 released

Interesting issue - that is indeed a use-case I didn't think about.

It's too bad that getColumns() doesn't return a "TABLE_TYPE" column that would match the types returned by
getTableTypes()

However, information_schema.columns does return columns from views, so those should at least be included
(although not getting columns for materialized views or types would mean I had to adjust my SQL Workbench for that)

Thomas


Dave Cramer schrieb am 16.10.2015 um 00:49:
> This was the original issue
>
> https://github.com/pgjdbc/pgjdbc/issues/374
>
> I don't think returning test_table_pkey is correct, hence the change
>
> Dave Cramer
>
> davec@postgresintl.com <mailto:davec@postgresintl.com>
> www.postgresintl.com <http://www.postgresintl.com>
>
> On 15 October 2015 at 18:19, Thomas Kellerer <spam_eater@gmx.net <mailto:spam_eater@gmx.net>> wrote:
>
>     Wouldn't it make more sense to _exclude_ those types that should
>     absolutely not appear there?
>
>     I don't really see the point of excluding anything there in the first place
>     to be honest.
>
>     This method won't get called "accidently" with some random object name.
>     If that is an index (or something else), that's what the user requested.
>
>     As indexes and tables share the same namespace there will never be
>     any ambiguity which object is meant.
>
>     Currently the driver also returns columns for types "create type foo as ..."
>     I do rely on that as well.
>
>     Regards
>     Thomas
>       Dave Cramer schrieb am 15.10.2015 um 23:53:
>
>         That's fine. I'll revert it. But I think the previous issue was that
>         it was also returning indexes as well. I'll just narrow down to
>         tables, views, and mat views
>
>         Dave Cramer
>
>         davec@postgresintl.com <mailto:davec@postgresintl.com> <mailto:davec@postgresintl.com
<mailto:davec@postgresintl.com>>
>         www.postgresintl.com <http://www.postgresintl.com> <http://www.postgresintl.com>
>
>         On 15 October 2015 at 17:39, Thomas Kellerer <spam_eater@gmx.net <mailto:spam_eater@gmx.net>
<mailto:spam_eater@gmx.net<mailto:spam_eater@gmx.net>>> wrote: 
>
>             All I can say is, that due to the nature of SQL Workbench (being DBMS independent) I do use (or at least
test)
>             many other DBMS and every[1] other JDBC driver does return view columns - including materialized views in
Oracleand DB2. 
>
>             So apparently all the other vendors think it makes sense to return view (and materialized view) columns.
>
>             Thomas
>
>             [1] I have tested at least briefly more than 15 different ones.
>
>
>
>
>
>     --
>     Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org <mailto:pgsql-jdbc@postgresql.org>)
>     To make changes to your subscription:
>     http://www.postgresql.org/mailpref/pgsql-jdbc
>
>