Bruce Momjian <bruce@momjian.us> writes:
> pg_upgrade uses that to find out of the server was already running or if
> we started it. This is to start the server to remove the
> postmaster.pid file. Also, no one has explained how not knowing if -o
> options were used was a safe.
What happened to the plan for pg_upgrade to use a new standalone
facility that also allows to run a normal psql in single-user mode?
IIRC the only thing we didn't want out of that patch was to market the
feature as an embedded mode of operations, because it's not, and some
level of faith that it's not blocking any future development of a proper
embedded mode.
Baring that, using the feature for pg_upgrade makes so much sense that
I'm left wondering why we're even still having the poor script trying to
decipher so much situations that the postmaster itself has no problem
dealing with.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support