Re: ALTER OBJECT any_name SET SCHEMA name

Alvaro Herrera <alvherre@commandprompt.com> writes:
> 1. wouldn't it make more sense to save the extension namespace in the
> extension catalog?

I don't think so, because the extension itself is not schema
qualified. What lives in the namespace the extension depends on is not
the extension itself, but its objects.

> 2. I think the guts of AlterExtensionNamespace (the large switch block)
> should be elsewhere, probably in alter.c

Makes sense, will move there.

> 3. Not this patch, but I think using "extension" as a global variable
> name is a bad idea.

What about create_extension_extension instead? I'm not thinking of
something better, bikeshedding is opened.

Regards,
-- 
Dimitri Fontaine
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support