On 2020/04/15 11:18, Fujii Masao wrote:
>
>
> On 2020/04/14 0:15, Robert Haas wrote:
>> On Sun, Apr 12, 2020 at 10:09 PM Fujii Masao
>> <masao.fujii@oss.nttdata.com> wrote:
>>> I found other minor issues.
>>
>> I think these are all correct fixes. Thanks for the post-commit
>> review, and sorry for this mistakes.
>
> Thanks for the review, Michael and Robert. Pushed the patches!
I found three minor issues in pg_verifybackup.
+ {"print-parse-wal", no_argument, NULL, 'p'},
This is unused option, so this line should be removed.
+ printf(_(" -m, --manifest=PATH use specified path for manifest\n"));
Typo: --manifest should be --manifest-path
pg_verifybackup accepts --quiet option, but its usage() doesn't
print any message for --quiet option.
Attached is the patch that fixes those issues.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION