Re: Fdw batch insert error out when set batch_size > 65535

Hi,

I took at this patch today. I did some minor changes, mostly:

1) change the code limiting batch_size from

    if (fmstate->p_nums > 0 &&
       (batch_size * fmstate->p_nums > PQ_QUERY_PARAM_MAX_LIMIT))
    {
        batch_size = PQ_QUERY_PARAM_MAX_LIMIT / fmstate->p_nums;
    }

to

    if (fmstate && fmstate->p_nums > 0)
        batch_size = Min(batch_size,
                         PQ_QUERY_PARAM_MAX_LIMIT / fmstate->p_nums);

which I think is somewhat clearer / more common patter.


2) I've reworded the docs a bit, splitting the single para into two. I
think this makes it clearer.


Attached is a patch doing this. Please check the commit message etc.
Barring objections I'll get it committed in a couple days.



regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company