On Mon, 2021-02-01 at 21:49 +0100, Daniel Gustafsson wrote:
> > Embedded NULLs are now handled in a similar manner to the OpenSSL side,
> > though because this failure happens during the certificate
> > authentication callback, it results in a TLS alert rather than simply
> > closing the connection.
>
> But returning SECFailure from the cert callback force NSS to terminate the
> connection immediately doesn't it?
IIRC NSS will send the alert first, whereas our OpenSSL implementation
will complete the handshake and then drop the connection. I'll rebuild
with the latest and confirm.
> > For easier review of just the parts I've changed, I've also attached a
> > since-v22.diff, which is part of the 0001 patch.
>
> I confused my dev trees and missed to include this in the v23 that I sent out
> (which should've been v24), sorry about that. Attached is a v24 which is
> rebased on top of todays --with-ssl commit, and now includes your changes.
No problem. Thanks!
--Jacob