Re: [HACKERS] ECPG: WHENEVER statement with DO CONTINUE action

Hi Sawada-san,

On 2017/06/20 17:22, Masahiko Sawada wrote:
> On Tue, Jun 20, 2017 at 1:51 PM, vinayak
> <Pokale_Vinayak_q3@lab.ntt.co.jp> wrote:
>>
>> On 2017/06/12 13:09, vinayak wrote:
>>
>> Hi,
>>
>> On 2017/06/10 12:23, Vinayak Pokale wrote:
>>
>> Thank you for your reply
>>
>> On Jun 9, 2017 5:39 PM, "Michael Meskes" <meskes@postgresql.org> wrote:
>>> Could you please add a "DO CONTINUE" case to one of the test cases? Or
>>> add a new one? We would need a test case IMO.
>>>
>> Yes I will add test case and send updated patch.
>>
>> I have added new test case for DO CONTINUE.
>> Please check the attached patch.
>>
>> I have added this in Sept. CF
>> https://commitfest.postgresql.org/14/1173/
>>
> I got the following warning by git show --check. I think you should
> remove unnecessary whitespace. Also the code indent of
> whenever_do_continue.pgc seems to need to be adjusted.
>
> $ git show --check
> commit a854aa0130589b7bd43b2c6c1c86651be91b1f59
> Author: Vinayak Pokale <vinpokale@gmail.com>
> Date:   Mon Jun 12 13:03:21 2017 +0900
>
>      WHENEVER statement DO CONTINUE support
>
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:16: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:21: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:24: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:27: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:35: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:37: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:39: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:41: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:47: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:49: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:52: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:54: trailing
> whitespace.
> +
> src/interfaces/ecpg/test/preproc/whenever_do_continue.pgc:1: new blank
> line at EOF.
>
> ------
> In whenever_do_continue.pgc file, the following line seems not to be
> processed successfully by ecpg but should we fix that?
>
> +
> +       exec sql whenever sqlerror continue;
> +
>
> Also, you wrote the test case using "WHENEVER sqlerror DO CONTINUE"
> action but that seems not to emit sqlerror, so "DO CONTINUE" is not
> executed. I think the test case for DO CONTINUE should be a C code
> that executes the "continue" clause.
Thank you for testing the patch.
I agreed with your comments. I will update the patch.

Regards,
Vinayak Pokale
NTT Open Source Software Center