Instability of pg_walsummary/002_blocks.pl due to timing
От | Alexander Lakhin |
---|---|
Тема | Instability of pg_walsummary/002_blocks.pl due to timing |
Дата | |
Msg-id | f35ba3db-fca7-4693-bc35-6db64488e4b1@gmail.com обсуждение исходный текст |
Список | pgsql-hackers |
Hello hackers, A couple of the 002.blocks test's failures occurred during past three months: [1], [2] with the following diagnostics: # Failed test 'WAL summarizer generates statistics for WAL reads' # at /home/bf/bf-build/culicidae/REL_18_STABLE/pgsql/src/bin/pg_walsummary/t/002_blocks.pl line 54. # got: 'f' # expected: 't' # Looks like you failed 1 test of 8. pgsql.build/testrun/pg_walsummary/002_blocks/log/regress_log_002_blocks [12:29:12.131](0.351s) ok 1 - WAL summarization caught up after insert [12:29:12.196](0.065s) not ok 2 - WAL summarizer generates statistics for WAL reads [12:29:12.198](0.002s) # Failed test 'WAL summarizer generates statistics for WAL reads' # at /home/bf/bf-build/culicidae/REL_18_STABLE/pgsql/src/bin/pg_walsummary/t/002_blocks.pl line 54. [12:29:12.198](0.000s) # got: 'f' # expected: 't' [12:29:12.267](0.069s) # after insert, summarized through 0/1821510 [12:29:12.507](0.240s) ok 3 - got new WAL summary after update This test case is rather new, it was added by f4694e0f3 (from 2025-03-05). I could reproduce this failure within 20 test runs with the following modification: --- a/src/backend/postmaster/walsummarizer.c +++ b/src/backend/postmaster/walsummarizer.c @@ -1544,6 +1544,7 @@ summarizer_read_local_xlog_page(XLogReaderState *state, * so we don't tight-loop. */ ProcessWalSummarizerInterrupts(); +pg_usleep(1000000); summarizer_wait_for_wal(); Michael, as you added the test case, could you please have a look? [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=tamandua&dt=2025-04-09%2007%3A36%3A05 [2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=culicidae&dt=2025-07-01%2010%3A23%3A38 Best regards, Alexander
В списке pgsql-hackers по дате отправления: