Re: [HACKERS] logical decoding of two-phase transactions

On 12/7/17 08:31, Peter Eisentraut wrote:
> On 12/4/17 10:15, Nikhil Sontakke wrote:
>> PFA, latest patch for this functionality.
> 
> This probably needs documentation updates for the logical decoding chapter.

You need the attached patch to be able to compile without warnings.

Also, the regression tests crash randomly for me at

frame #4: 0x000000010a6febdb
postgres`heap_prune_record_prunable(prstate=0x00007ffee5578990, xid=0)
at pruneheap.c:625
   622          * This should exactly match the PageSetPrunable macro.  We
can't store
   623          * directly into the page header yet, so we update working state.
   624          */
-> 625         Assert(TransactionIdIsNormal(xid));
   626         if (!TransactionIdIsValid(prstate->new_prune_xid) ||
   627             TransactionIdPrecedes(xid, prstate->new_prune_xid))
   628             prstate->new_prune_xid = xid;

Did you build with --enable-cassert?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services