On 4/6/21 13:45, tsunakawa.takay@fujitsu.com wrote:
> From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
>> We still have slow 'COPY FROM' operation for foreign tables in current master.
>> Now we have a foreign batch insert operation And I tried to rewrite the patch [1]
>> with this machinery.
>
> I haven't looked at the patch, but nice performance.
>
> However, I see the following problems. What do you think about them?
I agree with your fears.
Think about this patch as an intermediate step on the way to fast COPY
FROM. This patch contains all logic of the previous patch, except of
transport machinery (bulk insertion api).
It may be simpler to understand advantages of proposed 'COPY' FDW API
having committed 'COPY FROM ...' feature based on the bulk insert FDW API.
--
regards,
Andrey Lepikhov
Postgres Professional