Re: On login trigger: take three

Hi,

On 17.12.2020 3:31, Zhihong Yu wrote:
> Hi,
> For EventTriggerOnConnect():
>
> +           PG_CATCH();
> +           {
> ...
> +               AbortCurrentTransaction();
> +               return;
>
> Should runlist be freed in the catch block ?

No need: it is allocated in transaction memory context and removed on 
transaction abort.

>
> +           gettext_noop("In case of errors in the ON 
> client_connection EVENT TRIGGER procedure, this parameter can be used 
> to disable trigger activation and provide access to the database."),
>
> I think the text should be on two lines (current line too long).

Thank you, fixed.

-- 
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company