Hi Emre,
Thanks for the rebased patch. I remember reviewing the patch in the last
CF, and it seems in a pretty good shape. I plan to look at it again in
the next commitfest, but it seems to have been reviewed by other
experienced people so I'm not worried about this part.
The main remaining question I have is what do do with back-branches.
Shall we back-patch this or not?
The trouble is that while the patch is essentially a bugfix, it
refactors quite significant amount of code to make the fixes practical.
If it was possible to back-patch just the fixes without the refactoring,
that would be ideal, but unfortunately that's not the case. Based on
discussion with Emre in Ottawa that would be rather impractical due to
the nature of the bugs and low code reuse.
I do believe we should back-patch - after all, it fixes real bugs. It's
true the bugs were there for years and no one noticed/reported them, but
it's still buggy and that's not fun.
Opinions?
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services