Re: pgsql: Beautify initialization of JsonValueList andJsonLikeRegexContex

On 2019-03-17 10:59, Alexander Korotkov wrote:
> Beautify initialization of JsonValueList and JsonLikeRegexContext
> 
> Instead of tricky assignment to {0} introduce special macros, which
> explicitly initialize every field.

To me, this patch is exactly the opposite of what I'd do to "beautify
initialization".  It doesn't seem sustainable to me to create a special
macro for every structure in the code, not does it improve readability.
It is much clearer that {0} is uniformly the starting state.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services