On 7/26/24 11:00 PM, Jeff Davis wrote:
> Results (in ms):
>
> "C" "libc_c" overhead
> master: 6350 7855 24%
> v4-0001: 6091 6324 4%
I got more overhead in my quick benchmarking when I ran the same
benchmark. Also tried your idea with caching the last lookup (PoC patch
attached) and it basically removed all overhead, but I guess it will not
help if you have two different non.default locales in the same query.
"C" "libc_c" overhead
before: 6695 8376 25%
after: 6605 7340 11%
cache last: 6618 6677 1%
But even without that extra optimization I think this patch is worth
merging and the patch is small, simple and clean and easy to understand
and a just a clear speed up. Feels like a no brainer. I think that it is
ready for committer.
And then we can discuss after committing if an additional cache of the
last locale is worth it or not.
Andreas