Improve the test src/test/postmaster/t/003_start_stop.pl

Поиск
Список
Период
Сортировка
От Potapov Alexander
Тема Improve the test src/test/postmaster/t/003_start_stop.pl
Дата
Msg-id e5688-692bfe80-7-5e495f00@53075387
обсуждение исходный текст
Список pgsql-hackers
Hello,
 
This is about the TAP test src/test/postmaster/t/003_start_stop.pl. The test contains a loop that performs 21 iterations in order to occupy all possible connections. We could calculate the number of available connections more accurately. It relates to the size of backend pool that is defined in src/backend/postmaster/pmchild.c:
 
    pmchild_pools[B_BACKEND].size = 2 * (MaxConnections + max_wal_senders);
 
There are two points here: (1) in current implementation the test performs 11 extra iterations instead of 10 that are really needed. (2) We need to change the hardcoded value every time if the number of max connections or the number of max wal senders are changed. If we  use 2 * (MaxConnections + max_wal_senders) the test becomes a bit convinent.
 
A patch attached.
 
Best regards,
Alexander Potapov
Вложения

В списке pgsql-hackers по дате отправления: