Re: [COMMITTERS] pgsql: Unicode escapes in E'...' strings Author: Marko Kreen

Resend...

On 9/26/09, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Marko Kreen <markokr@gmail.com> writes:
>  > On 9/26/09, Peter Eisentraut <peter_e@gmx.net> wrote:
>
> >> That patch results in the following message from flex:
>  >>
>  >> psqlscan.l:1039: warning, -s option given but default rule can be
>  >> matched
>
>  > Agh.  Well, that just means the <xeu> state must be commented out:
>
>  >  -%x xeu
>  >  +/* %x xeu */
>
>
> Ick --- that breaks the whole concept of keeping the two sets of
>  flex rules in sync.  And it's quite unclear why it fixes the problem,
>  too.  At the very least, if you do it that way, it needs a comment
>  explaining exactly why it's different from the backend.

The commenting-out fixes the problem, because I copy pasted the state
declaration without any rules in it.

Anyway, now I attached a patch, where I filled the section but without
referring it from anywhere.  The rules itself are now equal.  Is that OK?

--
marko