On 6/1/09, Markus Wanner <markus@bluegap.ch> wrote:
> a newish conversion with cvs2git is available to check here:
>
> git://www.bluegap.ch/
>
> (it's not incremental and will only stay for a few days)
+1 for the idea of replacing CVS usernames with full names.
The knowledge about CVS usernames will be increasingly obscure.
Also worth mentioning is that there is no need to assign absolutely
up-to-date email addresses, it's enough if they uniquely identify
person.
> Aidan Van Dyk wrote:
> > Yes, but the point is you want an exact replica of CVS right? You're
> > git repo should have $PostgreSQL$ and the cvs export/checkout (you do
> > use -kk right) should also have $PostgreSQL$.
>
>
> No, I'm testing against cvs checkout, as that's what everybody is used to.
>
>
> > But it's important, because on *some* files you *do* want expanded
> > "keywords" (like the $OpenBSD ... Exp $. One of the reasons pg CVS went
> > to the $PostgreSQL$ keyword (I'm guessing) was so they could explictly
> > de-couple them from other keywords that they didn't want munging on.
>
>
> I don't care half as much about the keyword expansion stuff - that's
> doomed to disappear anyway.
But this is one aspect we need to get right for the conversion.
So preferably we test it sooner not later.
I think Aidan got it right - expand $PostgreSQL$ and others that are
actually expanded on current repo, but not $OpenBSD$ and others
coming from external sources.
> What I'm much more interested in is correctness WRT historic contents,
> i.e. that git log, git blame, etc.. deliver correct results. That's
> certainly harder to check.
>
> In my experience, cvs2svn (or cvs2git) does a pretty decent job at that,
> even in case of some corruptions. Plus it offers lots of options to fine
> tune the conversion, see the attached configuration I've used.
>
>
> > So, I wouldn't consider any conversion good unless it had all these:
> >
>
> > As well as stuff like:
> > parsecvs-master:src/backend/access/index/genam.c: * $PostgreSQL$
>
>
> I disagree here and find it more convenient for the git repository to
> keep the "old" RCS versions - as in the source tarballs that got (and
> still get) shipped. Just before switching over to git one can (and
> should, IMO) remove these tags to avoid confusion.
I'd prefer we immediately test full conversion and not leave some
steps to last moment.
--
marko