Re: Newline after --progress report

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: Newline after --progress report
Дата
Msg-id e4759a4d-4cf7-ca08-f0b8-d1cbd4721dc7@iki.fi
обсуждение исходный текст
Ответ на Re: Newline after --progress report  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Newline after --progress report  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 14/08/2020 16:51, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> Attached is a patch to fix this, as well as a similar issue in
>> pg_checksums. pg_basebackup and pgbench also print progres reports like
>> this, but they seem correct to me.
> 
> I wonder whether it'd be better to push the responsibility for this
> into progress_report(), by adding an additional parameter "bool last"
> or the like.  Then the callers would not need such an unseemly amount
> of knowledge about what progress_report() is doing.

Good point. Pushed a patch along those lines.

- Heikki



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: Commit/abort WAL records with dropped rels missing XLR_SPECIAL_REL_UPDATE