On 30/01/2019 07:16, Takashi Menjo wrote:
> Sorry but I found that the patchset v2 had a bug in managing WAL segment
> file offset. I fixed it and updated a patchset as v3 (attached).
I'm concerned with how this would affect the future maintenance of this
code. You are introducing a whole separate code path for PMDK beside
the normal file path (and it doesn't seem very well separated either).
Now everyone who wants to do some surgery in the WAL code needs to take
that into account. And everyone who wants to do performance work in the
WAL code needs to check that the PMDK path doesn't regress. AFAICT,
this hardware isn't very popular at the moment, so it would be very hard
to peer review any work in this area.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services