Re: Variable renaming in dbcommands.c

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: Variable renaming in dbcommands.c
Дата
Msg-id e2d87e67-e889-4768-b07e-181aef299086@eisentraut.org
обсуждение исходный текст
Ответ на Re: Variable renaming in dbcommands.c  (Daniel Gustafsson <daniel@yesql.se>)
Список pgsql-hackers
On 09.08.24 09:43, Daniel Gustafsson wrote:
>> On 9 Aug 2024, at 09:21, Peter Eisentraut <peter@eisentraut.org> wrote:
> 
>> In dbcommands.c function createdb(), there are several sets of very similar local variable names, such as "downer"
and"dbowner", which is very confusing and error-prone.  The first set are the DefElem nodes from the parser, the second
setare the local variables with the values extracted from them.  This patch renames the former to "ownerEl" and so on,
similarto collationcmds.c and typecmds.c, to improve clarity.
 
> 
> No objections, patch LGTM.

committed




В списке pgsql-hackers по дате отправления: