Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak

Поиск
Список
Период
Сортировка
От Qingqing Zhou
Тема Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Дата
Msg-id djb9vu$1k2p$1@news.hub.org
обсуждение исходный текст
Ответ на Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak  ("Magnus Hagander" <mha@sollentuna.net>)
Ответы Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance  (Andrew Dunstan <andrew@dunslane.net>)
Список pgsql-hackers
"Tom Lane" <tgl@sss.pgh.pa.us> wrote
>
> ... so definitely worth fixing for 8.1 if we can convince ourselves
> it's correct.
>

Despite the performance, there is one thing I am not exactly sure. Shall we 
add "volatile" quanlifier to at least pg_signal_queue? The dangerous place 
is PGSemaphoreLock(). If the compiler cache this value somehow, then we are 
in trouble, but the original way (check event directly) does not have this 
problem.

Regards,
Qingqing





В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Следующее
От: "Merlin Moncure"
Дата:
Сообщение: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak