On 6/15/17 10:58, Justin Pryzby wrote:
> On Thu, Jun 15, 2017 at 10:29:21AM -0400, Robert Haas wrote:
>> On Wed, Jun 14, 2017 at 6:28 PM, Justin Pryzby <pryzby@telsasoft.com> wrote:
>>> On Tue, Jun 13, 2017 at 12:16:00PM -0400, Robert Haas wrote:
>>>> It might be worth adding platform-specific code for common platforms.
>>>
>>> All I care (which linux happily/happens to support) is maxrss; I was probably
>>> originally interested in this while digging into an issue with hash agg.
>>
>> I don't think it needs to go in a separate file. I'd just patch ShowUsage().
I have committed a patch that shows maxrss, with /1024 adjustment for
macOS. That should cover all platforms that I could find.(*)
I omitted the i{x,d,s}rss stuff. My understanding is that to show them
you should divide the numbers by the elapsed time in some specific way.
Seeing that neither Linux or macOS fill these numbers in, I lost
interest. Someone could produce a separate patch to address this.
Since you were only interested in maxrss to begin with, I think this
thread is concluded.(*)
(*) modulo buildfarm wrath
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services