On 27.03.25 11:16, Peter Eisentraut wrote:
>> Patch 0002 also looks okay, except that the error handling could be
>> unified with existing code, as I had previously pointed out. Patch
>> 0005 fixes that.
>
> I plan to commit this one next, after the above had a bit of time to stew.
also done
>> About patch 0003:
>>
>> I had previously pointed out that the canonicalization might have been
>> intentional, and that we have canonicalization of ICU locale names.
>> But we don't have to keep the setlocale()-based locale checking
>> implementation just for that, I think. (If this was meant to be a
>> real feature offered by libc, there should be a
>> get_locale_name(locale_t) function.)
> Anyway, this patch fails tests on CI on NetBSD, so it will need some
> further investigation.
It turns out the problem was that nl_langinfo_l() returns a codeset name
of "646" for the C locale, which we didn't have in our mapping table.
If we add that, then everything passes there as well. (But the use of
nl_langinfo_l() wasn't added by this patch, it just exposes it to the
tests. So this is apparently a pre-existing problem.)
Attached are the remaining patches in this series.