Re: Missing program_XXX calling in pgbench tests

On 2025/06/05 10:18, Hayato Kuroda (Fujitsu) wrote:
> Dear hackers,
> 
> While reviewing another thread I found #SUBJECT.
> 
> Most of client program executes program_help_ok, program_version_ok,
> program_options_handling_ok() in their test, but pgbench does not do. Instead
> pgbench has own tests for --help and --version options.
> 
> One concern is that program_help_ok() checks whether lines are too long or not.
> For now, the rule seems to be kept but not sure in future.
> 
> I feel that we can replace tests with common function, like attached. How do you
> think?

+1

A bit similar discussion came up before regarding pgbench and program_xxx_ok
in [1], but it seems that change was never applied.

Regards,

[1] https://postgr.es/m/20180723033518.GG2854@paquier.xyz

-- 
Fujii Masao
NTT DATA Japan Corporation