Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput?
От
Euler Taveira
Тема
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput?
Дата
Msg-id
d97788f6-c1d9-4990-9e96-feada353da71@www.fastmail.com
Ответ на
Список
Дерево обсуждения
Any objections to implementing LogicalDecodeMessageCB for pgoutput? Dave Cramer <davecramer@gmail.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? Andres Freund <andres@anarazel.de>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? David Pirotte <dpirotte@gmail.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? Cary Huang <cary.huang@highgo.ca>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? Andres Freund <andres@anarazel.de>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? Michael Paquier <michael@paquier.xyz>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? Dave Cramer <davecramer@gmail.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? David Pirotte <dpirotte@gmail.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? David Pirotte <dpirotte@gmail.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? Euler Taveira <euler.taveira@2ndquadrant.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? Amit Kapila <amit.kapila16@gmail.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? "Euler Taveira" <euler@eulerto.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? Amit Kapila <amit.kapila16@gmail.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? "Euler Taveira" <euler@eulerto.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? Amit Kapila <amit.kapila16@gmail.com>
Re: Any objections to implementing LogicalDecodeMessageCB for pgoutput? "Euler Taveira" <euler@eulerto.com>
On Thu, Apr 1, 2021, at 7:19 AM, Amit Kapila wrote:
Your ideas/suggestions look good to me. Don't we need to provide aread function corresponding to logicalrep_write_message? We have itfor other write functions. Can you please combine all of your changesinto one patch?
Thanks for taking a look at this patch. I didn't consider a
logicalrep_read_message function because the protocol doesn't support it yet.
/*
* Logical replication does not use generic logical messages yet.
* Although, it could be used by other applications that use this
* output plugin.
*/
Someone that is inspecting the code in the future could possibly check this
discussion to understand why this function isn't available.
This new patch set version has 2 patches that is because there are 2 separate
changes: parse_output_parameters() refactor and logical decoding message
support.
В списке pgsql-hackers по дате отправления