On 25.09.2019 22:55, Alexander Korotkov wrote:
> On Mon, Sep 23, 2019 at 10:05 PM Alexander Korotkov
> <a.korotkov@postgrespro.ru> wrote:
>> I've reordered the patchset. I moved the most debatable patch, which
>> introduces RRRR and RR and changes parsing of YYY, YY and Y to the
>> end. I think we have enough of time in this release cycle to decide
>> whether we want this.
>>
>> Patches 0001-0005 looks quite mature for me. I'm going to push this
>> if no objections. After pushing them, I'm going to start discussion
>> related to RR, YY and friends in separate thread.
> Pushed. Remaining patch is attached. I'm going to start the separate
> thread with its detailed explanation.
Attached patch with refactoring of compareDatetime() according
to the complaints of Tom Lane in [1]:
* extracted four subroutines for type conversions
* extracted subroutine for error reporting
* added default cases to all switches
* have_error flag is expected to be not-NULL always
* fixed errhint() message style
[1] https://www.postgresql.org/message-id/32308.1569455803%40sss.pgh.pa.us
--
Nikita Glukhov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company