Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition
| От | ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) |
|---|---|
| Тема | Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition |
| Дата | |
| Msg-id | d8jimnzq3ow.fsf@dalvik.ping.uio.no обсуждение |
| Ответ на | Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition
|
| Список | pgsql-hackers |
Tom Lane <tgl@sss.pgh.pa.us> writes: > ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes: >> I just noticed that when contrib/seg was converted to V1 calling >> convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined >> in terms of PG_GETARG_POINTER(). But it itself calls DatumGetPointer(), >> so shouldn't it be using PG_GETARG_DATUM()? > > Yup, I agree. Pushed. Thanks! > regards, tom lane - ilmari -- "The surreality of the universe tends towards a maximum" -- Skud's Law "Never formulate a law or axiom that you're not prepared to live with the consequences of." -- Skud's Meta-Law
В списке pgsql-hackers по дате отправления: