Re: [PATCH] Add CANONICAL option to xmlserialize

On 2026-03-23 Mo 5:52 AM, Jim Jones wrote:
> rebase + minor changes:
>
> * remove unnecessary volatile qualifier from a variable only read by
> PG_TRY and never accessed by PG_CATCH or PG_END_TRY
> * remove old comment from xml.sql and unnecessary entry from
> system_functions.sql (leftovers from last implementation)
> * add the c14n enum XML_C14N_1_1 instead of its value in the
> xmlC14NDocDumpMemory() call.
>


Here's a very minor tidy up:

- Split Datum xmlcanonicalize(PG_FUNCTION_ARGS) across two lines
- Fixed variable declaration alignment
- Replaced 11-line verbose comment with a single-line /* Canonicalize 
the entire document using C14N 1.1 */
- Moved #include <libxml/c14n.h> to alphabetical position
- Removed unnecessary if (doc) / if (xmlbuf) guards on the success-path 
cleanup
- Added spaces after casts: (xmlDocPtr) doc, (xmlChar *) xmlbuf, 
(xmlChar **) &xmlbuf

I note that your function returns xml, whereas Tom's suggestion was for 
a function returning text. I don't think there was any discussion on the 
point.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com