Re: Fix bug in multixact Oldest*MXactId initialization and access

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: Fix bug in multixact Oldest*MXactId initialization and access
Дата
Msg-id d820058d-1aec-4f7b-8d08-38e68ab3a91f@iki.fi
обсуждение
Ответ на Re: Fix bug in multixact Oldest*MXactId initialization and access  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 03/03/2026 20:47, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> On 03/03/2026 17:22, Tom Lane wrote:
>>> I wonder if we couldn't reduce future maintenance effort for
>>> prepared_xacts_1.out by modifying that test script to make an
>>> early exit if prepared transactions are disabled.
> 
>> +1, I was just thinking the same.
> 
> Personally I'd put the exit test after the file's header comment,
> but that's just a quibble.  LGTM otherwise.

Yeah I agree it would look a little neater, but I put the exit test 
first so that the comment doesn't get echoed to the output when the test 
isn't run. That way we don't need to remember to update 
prepared_xacts_1.out if we change the header comment. It hasn't changed 
for 20 years, but still :-).

Committed, thanks!

- Heikki




В списке pgsql-hackers по дате отправления: