Re: [PATCH] Add `headerscheck` run_target to meson

On 18.03.26 16:36, Nazir Bilal Yavuz wrote:
> Hi,
> 
> On Wed, 18 Mar 2026 at 14:59, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> On 18.03.26 11:56, Peter Eisentraut wrote:
>>>
>>> Committed that, but without the regular expression changes.  I don't
>>> understand why those would be needed.  Please provide more information
>>> if necessary.  It worked for me without it.
> 
> It is working now. I can't reproduce the problem, it looks like it is
> already fixed.
> 
> 
>> I need another tweak for the cpluspluscheck.
>>
>> In meson, the distribution of the include flags between CPPFLAGS,
>> CFLAGS, and CXXFLAGS ends up being a bit different, and we need to get a
>> few -I options from CXXFLAGS in my case.
>>
>> I have attached two different variants for how to do this.  The first
>> one just gets the -D and -I flags from CXXFLAGS.  This preserves most of
>> the existing behavior.  The second aligns more with how CFLAGS works and
>> removes the ability to override CXXFLAGS from the command line.  This is
>> probably now better since we have more support for getting correct CXX
>> and CXXFLAGS in the build system.  But it might be a change for some users.
>>
>> Thoughts?
> 
> I think we can go with the second variant first. If there is a
> complaint, we can then consider switching to the first one. Does that
> sound good? Also, second patch probably needs to remove lines below
> from the src/tools/pginclude/README:
> 
> ```
> If you are using a non-g++-compatible C++ compiler, you may need to
> override the script's CXXFLAGS setting by setting a suitable environment
> value.
> ```

Ok, done that way.