On 2023-08-21 Mo 12:30, Tom Lane wrote:
Andrew Dunstan <andrew@dunslane.net> writes:
On 2023-08-21 Mo 08:33, Alvaro Herrera wrote:
Hmm ... when exactly do these values get freed if no longer needed? Is
the theory that leaking them is not relevant?
Not sure I understand "relevant" here. They don't get freed. There will
be at most one entry per row in pg_attribute where atthasmissing is
true.
Yeah. My feeling is that as long as we don't make duplicate hashtable
entries, there will never be so many entries that it'd be worth the
cost and intellectual complexity of trying to clean them up. When
and if that theory is disproven, we can think harder; but for now
I think this approach is good enough.
Fix pushed to all relevant branches.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com