Re: StringInfo misc. issues

Поиск
Список
Период
Сортировка
От NikhilS
Тема Re: StringInfo misc. issues
Дата
Msg-id d3c4af540708292301p45027cand50aea3d29191dab@mail.gmail.com
обсуждение исходный текст
Ответ на Re: StringInfo misc. issues  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Apologies! As Alvaro guessed it correctly I was working with 8.2 sources. Sorry for the noise.

Regards,
Nikhils

On 8/29/07, Tom Lane < tgl@sss.pgh.pa.us> wrote:
NikhilS <nikkhils@gmail.com > writes:
> The attached patch should fix this.

And break other things, no doubt.  needed = 0 is a perfectly valid
edge case and mustn't be rejected here.  (In fact, I doubt you'd
even get through the regression tests with this patch ... how much
did you test it?)

The real problem with what you describe is that you should have used
makeStringInfo().

> I also found the absence of a function like resetStringInfo() a bit
> puzzling.

CVS HEAD is way ahead of you.

                        regards, tom lane



--
EnterpriseDB               http://www.enterprisedb.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Advice on MyXactMade* flags, MyLastRecPtr, pendingDeletes and lazy XID assignment
Следующее
От: Gregory Stark
Дата:
Сообщение: Re: Why is there a tsquery data type?