On 25.01.22 02:07, Justin Pryzby wrote:
> +CREATE TABLE pg_settings_flags AS SELECT name, category,
> + 'NO_SHOW_ALL' =ANY(flags) AS no_show_all,
> + 'NO_RESET_ALL' =ANY(flags) AS no_reset_all,
> + 'NOT_IN_SAMPLE' =ANY(flags) AS not_in_sample,
> + 'EXPLAIN' =ANY(flags) AS guc_explain,
> + 'COMPUTED' =ANY(flags) AS guc_computed
> + FROM pg_show_all_settings();
Does this stuff have any value for users? I'm worried we are exposing a
bunch of stuff that is really just for internal purposes. Like, what
value does showing "not_in_sample" have? On the other hand,
"guc_explain" might be genuinely useful, since that is part of a
user-facing feature. (I don't like the "guc_*" naming though.)
Your patch doesn't contain a documentation change, so I don't know how
and to what extend this is supposed to be presented to users.