On 2019/03/28 18:31, Amit Langote wrote:
> Hi,
>
> On 2019/03/28 18:12, Peter Eisentraut wrote:
>> On 2019-03-22 01:21, Amit Langote wrote:
>>> On 2019/03/22 2:23, David Steele wrote:
>>>> On 3/14/19 6:19 AM, Amit Langote wrote:
>>>>> On 2019/03/14 2:11, Pavel Stehule wrote:
>>>>>>
>>>>>>> I've attached v11 of the patch, which merges most of Justin's changes and
>>>>>>> some of my own on top -- documentation and partition size column names.
>>>>>
>>>>> Maybe, we should set this ready for committer then?
>>>>
>>>> There don't appear to be any objections. Perhaps you should do that?
>>>
>>> OK, done.
>>
>> What is the purpose of this patch (hint: commit message)? The email
>> subject is "show size of partitioned table", which seems reasonable, but
>> looking briefly at a patch, it adds new psql commands to display
>> partitioned tables only. I don't understand the purpose of that.
>>
>> (Moreover, who is the author of this patch? Is the commit fest entry
>> accurate?)
>
> It's mainly Pavel's patch, which I've occasionally posted updated versions
> of, when it appeared to me that Pavel might be busy with other stuff.
>
> As mentioned somewhere at the top of this thread, the main reason behind
> proposing a new command \dP is that some people didn't much like the idea
> that \d+ command itself be modified to gather all partitions and add their
> sizes to be shown as the size of the partitioned tables. More features
> got added later on to account for partitioned indexes, showing
> sub-partitioned tables in addition to root tables that are shown by
> default, etc.
>
> Maybe, Pavel can say more...
Ah, his message got in before mine.
Thanks,
Amit