Re: why there is not VACUUM FULL CONCURRENTLY?

Euler Taveira <euler@eulerto.com> wrote:

> +

> +     <warning>

> +      <para>

> +       The <command>FULL</command> parameter is deprecated in favor of

> +       <xref linkend="sql-repack"/>.

> +      </para>

> +     </warning>

> +

> 

> The warnings, notes, and tips are usually placed *after* the description.

You probably mean the subsecions "Notes on Clustering" and "Notes on

Resources". I moved them into the "Notes" section.

> +    SELECT

> +        S.pid AS pid,

> +        S.datid AS datid,

> +        D.datname AS datname,

> +        S.relid AS relid,

> +        CASE S.param1 WHEN 1 THEN 'REPACK'

> +                      END AS command,

> 

> Do you really need command? IIUC REPACK is the only command that will used by

> this view. There is no need to differentiate commands here.

REPACK is a regular command, so why shouldn't it have its view? Just like

CLUSTER has one (pg_stat_progress_cluster).

> + *

> + * 'cmd' indicates which commands is being executed. REPACK should be the only

> + * caller of this function in the future.

> 

> command.

Not sure I understand this comment.