On 9/17/19 12:09 PM, Erik Rijkers wrote:
> On 2019-09-17 17:38, Jonathan S. Katz wrote:
>> [regex.patch]
Thanks for the review!
> "Several other parts of the SQL standard
> also define LIKE_REGEX equivalents that refer
> to this implementation, including the
> SQL/JSON path like_regex filter."
>
> As I understand this text, 'concept' seems better.
> I'd drop 'also', too.
I rewrote this to be:
"Several other parts of the SQL standard refer to the LIKE_REGEX
specification to define similar operations, including..."
> 2.
> 'whereas the POSIX will those' should be
> 'whereas POSIX will regard those'
> or maybe 'read those'
I used "treat those"
>
> 3.
> + The SQL/JSON standard borrows its definition for how regular
> expressions
> + from the <literal>LIKE_REGEX</literal> operator, which in turns
> uses the
> + XQuery standard.
> That sentence needs the verb 'work', no? 'for how regular expressions
> work [..]'
> Or alternatively drop 'how'.
I dropped the "how".
v2 attached. Thanks!
Jonathan