Re: Memory leak in WAL sender with pgoutput (v10~)
| От | Euler Taveira |
|---|---|
| Тема | Re: Memory leak in WAL sender with pgoutput (v10~) |
| Дата | |
| Msg-id | cc9d5c5f-c807-4bcb-a862-170ba944da3f@app.fastmail.com обсуждение исходный текст |
| Ответ на | Re: Memory leak in WAL sender with pgoutput (v10~) (Amit Kapila <amit.kapila16@gmail.com>) |
| Список | pgsql-hackers |
On Thu, Dec 5, 2024, at 1:31 AM, Zhijie Hou (Fujitsu) wrote:
No problem. Here is the patch for the HEAD. This patch introduces a new memorycontext within PGOutputData, specifically for allocating memory forpublication_names. The new memory context is nested under the logical decodingcontext, ensuring it is freed at the end of decoding throughFreeDecodingContext.
Thanks for taking care of it. I suggest 2 small adjustments: (a) use
ALLOCSET_SMALL_SIZES instead of ALLOCSET_DEFAULT_SIZES and (b) replace
pubmemcxt with pubmemctx (that's the same abbreviation used by
cachectx). I think you could remove 'mem' from this variable. My
suggestions are pubcxt or pubnamescxt. Although, I prefer the former, if
other publication elements are added to this context in the future.
В списке pgsql-hackers по дате отправления: