Re: Using PQexecQuery in pipeline mode produces unexpected Close messages
| От | Álvaro Herrera |
|---|---|
| Тема | Re: Using PQexecQuery in pipeline mode produces unexpected Close messages |
| Дата | |
| Msg-id | cbddf6bf-aa06-47fa-ab1d-d73a58d4e89f@www.fastmail.com обсуждение |
| Ответ на | Re: Using PQexecQuery in pipeline mode produces unexpected Close messages (Kyotaro Horiguchi <horikyota.ntt@gmail.com>) |
| Ответы |
Re: Using PQexecQuery in pipeline mode produces unexpected Close messages
|
| Список | pgsql-hackers |
On Fri, Jun 10, 2022, at 8:25 AM, Kyotaro Horiguchi wrote:
The current implement of PQsendQueryInternal looks like the result ofa misunderstanding of the doc. In the regression tests, that path isexcercised only for an error case, where no CloseComplete comes.The attached adds a test for the normal-path of pipelinedPQsendQuery() to simple_pipeline test then modifies that function notto send Close message. Without the fix, the test fails by "unexpectednotice" even if the trace matches the "expected" content.
Hah, the patch I wrote is almost identical to yours, down to the notice processor counting the number of notices received. The only difference is that I put my test in pipeline_abort.
Sadly, it looks like I won't be able to get this patched pushed for 14.4.
В списке pgsql-hackers по дате отправления: