On 11/26/21 04:12, Daniel Gustafsson wrote:
>> On 26 Nov 2021, at 05:45, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Personally I'm not really in favour of outright disabling the C4101
>>> warning on Windows, because I think it is a useful warning for
>>> Postgres developers on Windows for cases unrelated to the use of
>>> PG_USED_FOR_ASSERTS_ONLY.
> I'm not sure I find it useful, as the only reason I *think* I know what it's
> doing is through trial and error. The only warnings we get from a tree where
> PG_USED_FOR_ASSERTS_ONLY clearly does nothing, are quite uninteresting and
> fixing them only amounts to silencing the compiler and not improving the code.
>
I agree with Tom. I don't think we should disable the warning. If we
can't come up with a reasonable implementation of
PG_USED_FOR_ASSERTS_ONLY that works with MSVC we should just live with
the warnings. It's not like we get flooded with them.
cheers
andrew