Re: [PATCH] Negative Transition Aggregate Functions (WIP)

On Thu, January 2, 2014 13:05, David Rowley wrote:
> here's a slightly updated patch
> [inverse_transition_functions_v1.8.patch.gz ]

patch applies, and compiles (although with new warnings).
But make check complains loudly: see attached.


warnings:


In file included from gram.y:13871:0:
scan.c: In function â:
scan.c:10167:23: warning: unused variable â [-Wunused-variable]
 struct yyguts_t * yyg = (struct yyguts_t*)yyscanner; /* This var may be unused depending upon options. */
                   ^
In file included from ../../../../src/include/utils/probes.h:6:0,
                 from ../../../../src/include/pg_trace.h:15,
                 from tuplesort.c:109:
tuplesort.c: In function â:
tuplesort.c:935:44: warning: comparison between pointer and integer [enabled by default]
  TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);
                                            ^
tuplesort.c:935:2: note: in expansion of macro â
  TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);



I didn't yet use the patch you sent after this patch.


Thanks,

Erik Rijkers